Skip to content

feat: implement consistent retry logic for topic writer #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 3, 2024
Merged

feat: implement consistent retry logic for topic writer #223

merged 7 commits into from
Dec 3, 2024

Conversation

@KirillKurdyukov
Copy link
Collaborator

@KirillKurdyukov KirillKurdyukov commented Dec 3, 2024 •
edited
Loading

  • Do not send messages that have a timeout by cancelToken.
  • If your value serializer throws an exception, this will be wrapped in a WriterException with unspecified status.
  • Added BufferOverflowRetryTimeoutMs to the next try write.
  • Rename _disposeTokenSource -> _disposeCts.
  • Optimize write worker: if (_toSendBuffer.IsEmpty) continue.
  • On RPC errors create DummyWriterSession.
  • Message has been skipped because its sequence number is less than or equal to the last processed server's SeqNo.
  • Calculate the next sequence number from the calculated previous messages.

@github-actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

🌋 Here are results of SLO test for .NET SDK over table-service:

Grafana Dashboard

SLO-table-service

@github-actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

🌋 Here are results of SLO test for ADO.NET over query-service:

Grafana Dashboard

SLO-ado-net

@KirillKurdyukov KirillKurdyukov merged commit df0639e into main Dec 3, 2024
25 checks passed
@KirillKurdyukov KirillKurdyukov deleted the feat-writer-retry-always branch December 3, 2024 17:34
@KirillKurdyukov KirillKurdyukov linked an issue Dec 3, 2024 that may be closed by this pull request
Topic writer #32
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Topic writer

2 participants

@KirillKurdyukov